Fix #18 issue, aligned Bundle class with the ontology #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
…lities; revert Identity typing Trying to use `uco.identity.Identity` in `base.py` resulted in Python failing on a circular import. A follow-on patch will regenerate Make-managed files. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
@fabrizio-turchi : I don't believe this PR, as you'd started it, addresses Issue 18. However, it did get the ball rolling on some revisions that needed to happen anyway, promoting keyword arguments that were specific to Bundle to their appropriate constructor w.r.t. where the properties are constrained in the ontology.
I'm approving and merging this PR to separate from other code motion that could happen in consideration of placing the context dictionary. I'll post that discussion on the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.