Expand icon column of tags table to store extended emoji (#141)

cash-track · Nov 19, 2023 · 5a0554a · 5a0554a
2 parents 715261d + 04e927d
commit 5a0554a
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 5 deletions.
diff --git a/app/migrations/20231119.084012_0_expand_tags_icon_column2.php b/app/migrations/20231119.084012_0_expand_tags_icon_column2.php
@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App;
+
+use Cycle\Migrations\Migration;
+
+class ExpandTagsIconColumnMigration2 extends Migration
+{
+    public function up(): void
+    {
+        $this->table('tags')
+             ->alterColumn('icon', 'string', [
+                 'nullable' => true,
+                 'default'  => null,
+                 'size'     => 10,
+             ])
+             ->update();
+    }
+
+    public function down(): void
+    {
+        $this->table('tags')
+             ->alterColumn('icon', 'string', [
+                 'nullable' => true,
+                 'default'  => null,
+                 'size'     => 4,
+             ])
+             ->update();
+    }
+}
diff --git a/app/src/Database/Tag.php b/app/src/Database/Tag.php
@@ -22,7 +22,7 @@ class Tag
     #[ORM\Column(type: 'integer', name: 'user_id')]
     public int $userId = 0;
 
-    #[ORM\Column(type: 'string(4)', nullable: true)]
+    #[ORM\Column(type: 'string(10)', nullable: true)]
     public string|null $icon = null;
 
     #[ORM\Column(type: 'string', nullable: true)]

diff --git a/app/src/Request/Tag/CreateRequest.php b/app/src/Request/Tag/CreateRequest.php
@@ -39,7 +39,7 @@ public function filterDefinition(): FilterDefinitionInterface
             ],
             'icon' => [
                 ['is_string'],
-                ['string::range', 1, 7],
+                ['string::range', 1, 10],
             ],
             'color' => [
                 ['is_string'],

diff --git a/app/src/Request/Tag/UpdateRequest.php b/app/src/Request/Tag/UpdateRequest.php
@@ -43,7 +43,7 @@ public function filterDefinition(): FilterDefinitionInterface
             ],
             'icon' => [
                 ['is_string'],
-                ['string::range', 1, 7]
+                ['string::range', 1, 10]
             ],
             'color' => [
                 ['is_string'],

diff --git a/tests/Feature/Controller/Tags/TagsControllerTest.php b/tests/Feature/Controller/Tags/TagsControllerTest.php
@@ -107,7 +107,7 @@ public function createValidationFailsDataProvider(): array
             ], ['name', 'icon', 'color']],
             [[
                 'name' => 't',
-                'icon' => '12345678',
+                'icon' => '01234567891',
                 'color' => '#123abcg'
             ], ['name', 'icon', 'color']],
             [[
@@ -288,7 +288,7 @@ public function updateValidationFailsDataProvider(): array
             ], ['name', 'icon', 'color']],
             [[
                 'name' => 't',
-                'icon' => '12345678',
+                'icon' => '01234567891',
                 'color' => '#123abcg'
             ], ['name', 'icon', 'color']],
             [[