Migrate to libs.versions.toml #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkerford
reviewed
Jan 15, 2024
build.gradle.kts
Outdated
| @@ -56,7 +56,7 @@ subprojects { | |||
| configure<SpotlessExtension> { | |||
| kotlin { | |||
| target("**/*.kt") | |||
| ktlint(Versions.ktlint).editorConfigOverride( | |||
| ktlint("0.47.1").editorConfigOverride( | |||
There was a problem hiding this comment.
can we make this a reference to a version in the lib.version.toml?
There was a problem hiding this comment.
+1. The versions that were at the bottom of Dependencies.kt could go into the [versions] section of libs.versions.toml and then you can reference them here and in other places like libs.versions.ktlint.get()
lkerford
approved these changes
Jan 15, 2024
staktrace
approved these changes
Jan 15, 2024
service/build.gradle.kts
Outdated
|
|
||
| // Dependencies for fake development services | ||
| // libs.for fake development services |
There was a problem hiding this comment.
my regex went too far here :)
build.gradle.kts
Outdated
| @@ -56,7 +56,7 @@ subprojects { | |||
| configure<SpotlessExtension> { | |||
| kotlin { | |||
| target("**/*.kt") | |||
| ktlint(Versions.ktlint).editorConfigOverride( | |||
| ktlint("0.47.1").editorConfigOverride( | |||
There was a problem hiding this comment.
+1. The versions that were at the bottom of Dependencies.kt could go into the [versions] section of libs.versions.toml and then you can reference them here and in other places like libs.versions.ktlint.get()
adrw
force-pushed
the
adrw.2024-01-15.migrateVersions
branch
from
3be7701 to
ceaa900
Compare
mpawliszyn
force-pushed
the
adrw.2024-01-15.migrateVersions
branch
from
ceaa900 to
c4c13c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.