Adds in conversion to and from Result<Option<A>> and OutcomeOf<A> #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwmyers
requested review from
Synesso,
hugomd and
millyrowboat
as code owners
cwmyers
commented
Sep 10, 2024
Comment on lines
+244
to
+245
| fun <A> OutcomeOf<A>.asResult(): Result<Option<A>> = inner.toResult() | ||
|
|
There was a problem hiding this comment.
Ideally this should be toResult but that clashes with Outcome<E,A>.toResult and this is a precedence in this codebase.
cwmyers
commented
Sep 10, 2024
Comment on lines
+486
to
+496
| "can transform from result to OutcomeOf and back again" { | ||
| checkAll(Arb.result(Throwable("boom"), Arb.option(Arb.int()))) { input -> | ||
| input.toOutcomeOf().asResult() shouldBe input | ||
| } | ||
| } | ||
|
|
||
| "can transform from OutcomeOf to result and back again" { | ||
| checkAll(Arb.outcomeOf(Throwable("boom"), Arb.int())) { outcome -> | ||
| outcome.asResult().toOutcomeOf() shouldBe outcome | ||
| } | ||
| } |
There was a problem hiding this comment.
Round trip property based tests
Synesso
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutcomeOf<A>is essentially aResult<Option<A>>as the error side is locked down to aThrowable. This PR makes it easier to convert between the two.