Contribution from cc-wallet dev session #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainnet-pat
commented
Aug 8, 2024
•
mainnet-pat
commented
- brand new wallet history tab with great overview of your activity
- transaction inspection window with FT and NFT icons preview
- multi-currency support (currently only EUR is hardcoded, but others could be added to dropdown too, see https://bitpay.com/rates/BCH for list of other currencies)
- featured (pinned) token support, wallet could be opened with a reflink such as localhost:9000/addToken/d9ab24ed15a7846cc3d9e004aa5cb976860f13dac1ead05784ee4f4622af96ea to add a token to favorites
- add token fiat value display in tokens, history and transactions views
- add qrcode scanning dialog, use it on wallet page for address scans and on wallet connect page for wc qr recognition, thanks @paytaca
- wallet connect and token creation could be toggled to be shown and hidden in main menu list
- other improvements
Featured tokens will always be displayed, event if the wallet does not have them (zero balance)
…s, defaults to false
…ggle to the right
…ken/:tokenId which will automatically add the token to the list of favorites
…anced settings menu button to clear the cached application data such as cached prices
…nd on wallet connect page for wc qr recognition
…dren components Add a filter hint to the qr-scan dialog which will appear if decoded text does not match the required format
mainnet-pat
force-pushed
the
upstream_pr
branch
from
e64137b to
ec88e6e
Compare
…to speed up wallet loading
|
The changes have been deployed for testing here: https://cc-wallet-bch.vercel.app/ I like the idea of making token creation a tab you need to enable, and replacing it by the history tab
|
|
the latest commit adds caching for bcmr & auth lookups
|
|
So I'm doing the backposts one-by-one, because I rework the code & UI somewhat and because of merge conflicts. I already did 2 backports
remaining features (6)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.