NUT-17: WebSocket updates #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callebtc
reviewed
Nov 5, 2024
alexlwn123
reviewed
Nov 8, 2024
| export class WSConnection { | ||
| public readonly url: URL; | ||
| private readonly _WS: typeof WebSocket; | ||
| private ws: WebSocket | undefined; |
There was a problem hiding this comment.
Should these private fields be prefixed by _? like the classes in utils?
| } | ||
| } | ||
| } catch (e) { | ||
| console.log(e); |
There was a problem hiding this comment.
Should this try to call the errorCallback?
| }; | ||
|
|
||
| type JsonRpcSuccess<T = any> = { | ||
| jsonrpc: '2.0'; |
There was a problem hiding this comment.
maybe make jsonrpc readonly, to make sure the editor doesn't display the type as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: none
Description
This adds WebSocket management, as well as a couple of methods on CashuWallet for full NUT-17 support
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format