Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NUT-06: deprecate amount in PostSplitRequest #85

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Update NUT-06: deprecate amount in PostSplitRequest #85

merged 2 commits into from
Sep 20, 2023

Conversation

callebtc
Copy link
Contributor

@callebtc callebtc commented Sep 14, 2023 •
edited
Loading

implements update in nut-06 deprecating the amount field in PostSplitRequest and only returning promises in PostSplitResponse.

Partly overlaps with #77

@callebtc callebtc mentioned this pull request Sep 14, 2023
Closed
1 task
@callebtc callebtc changed the title update nut06: deprecate amounts Update NUT-06: deprecate amount in PostSplitRequest Sep 14, 2023
@callebtc callebtc mentioned this pull request Sep 14, 2023
Merged
14 tasks
@gandlafbtc
Copy link
Collaborator

please run npm run format

@dipunm dipunm mentioned this pull request Sep 17, 2023
Closed
@gandlafbtc
Copy link
Collaborator

oops, this is already included in #77 ? or no? @callebtc

@callebtc
Copy link
Contributor Author

oops, this is already included in #77 ? or no? @callebtc

Partially, yes. This PR is an independent reimplementation of the NUT update. I think this should be in two separate PRs.

gandlafbtc
gandlafbtc approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@gandlafbtc gandlafbtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiice!

@gandlafbtc gandlafbtc merged commit 340d30d into main Sep 20, 2023
3 checks passed
@gandlafbtc gandlafbtc deleted the nut06/deprecate_amount branch September 20, 2023 10:05
@gandlafbtc gandlafbtc mentioned this pull request Sep 21, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandlafbtc gandlafbtc gandlafbtc approved these changes

@BilligsterUser BilligsterUser Awaiting requested review from BilligsterUser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@callebtc @gandlafbtc