improve: handle trailing and duplicate / in mint urls

[thesimplekid]

Description

I've been having an issue where mint urls with a trailing / will cause errors in this library as it ends up with duplicate / in the mint urls. This adds a joinUrls function to remove duplicate / when joining url instead of just appending the path to the mint url string,

The other way I thought to do this is to strip the trailing / when creating a new mint. However, since these functions are publicly exposed think its best to handle mint urls that maybe passed in with a trailing /.

...

Changes

Add: Util joinUrls

PR Tasks

• Open PR
• run npm run test --> no failing unit tests
• run npm run format

[gandlafbtc]

LGTM, Thanks for the PR!

There is one thing that might be a footgun, which is that the mint URL can act as kind-of an ID. and by allowing this we could end up with 2 "IDs" for 1 mint, if not handled correctly by the client. one with / and one without.

I still think it's better to make this the clients problem, and not the libraries. The lib should accept both 👍

[thesimplekid]

There is one thing that might be a footgun, which is that the mint URL can act as kind-of an ID. and by allowing this we could end up with 2 "IDs" for 1 mint, if not handled correctly by the client. one with `/` and one without.

Yes, I had this problem in the cashu-crab rust crate, and handle it similarly where it is up to the client to not duplicate mints.

…

On September 19, 2023 8:09:47 AM GMT+01:00, gandlafbtc ***@***.***> wrote: @gandlafbtc approved this pull request. LGTM, Thanks for the PR! There is one thing that might be a footgun, which is that the mint URL can act as kind-of an ID. and by allowing this we could end up with 2 "IDs" for 1 mint, if not handled correctly by the client. one with `/` and one without. I still think it's better to make this the clients problem, and not the libraries. The lib should accept both 👍

[callebtc]

Nice one