Refactored request error handling
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! looking forward to this |
|
Should I include the second part into this PR? I was planning on getting this reviewed and merged and then following up with a second PR. |
|
what kind of files would the 2nd pr touch? |
|
The CashuWallet.ts file
It will change the signature of the methods. I've put details in the issue.
…On Sun, 1 Oct 2023, 08:32 gandlafbtc, ***@***.***> wrote:
what kind of files would the 2nd pr touch?
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABG5DTCSXWNZFDCIH2RSZCLX5EMCFANCNFSM6AAAAAA47AD7UE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
okay... i have a PR coming that changes a bunch in |
|
i'll rebase this branch after i merged the branch |
Exception is now identifiable as HttpResponseError providing a status code. Breaking? We no longer look for error messages on `ok` responses. (HTTP2XX)
gandlafbtc
force-pushed
the
error-handling
branch
from
bb11590
to
fc93b5c
Compare
gandlafbtc
reviewed
Jan 18, 2024
gandlafbtc
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception is now identifiable as HttpResponseError providing a status code.
Breaking? We no longer look for error messages on
okresponses. (HTTP2XX)Fixes: Not yet.
Description
This is a small PR as part of an ongoing effort to address #86
...
Changes
okresponses. (HTTP2XX)PR Tasks
npm run test--> no failing unit testsnpm run format