[NUT-15] LND Support for MPP Payments #536
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ..Default::default() | ||
| }) | ||
| .await | ||
| .map_err(|_| Error::PaymentFailed)? |
There was a problem hiding this comment.
Wont this return here due to the use of ? so if the payment fails the next route cannot be tried?
There was a problem hiding this comment.
I think we only want to try more routes if we get a specific error 15 (TEMPORARY_CHANNEL_FAILURE). If we get any other kind of error then something else is up.
crates/cdk-lnd/src/lib.rs
Outdated
| .map_or(0, |route| route.total_amt_msat / MSAT_IN_SAT as i64) | ||
| as u64; | ||
| // Detect partial payments | ||
| if let Some(part_amt) = partial_amount { |
There was a problem hiding this comment.
NIT: Since we care about both paths the Some and None we should use a match and not if let to be consistent with code style https://github.com/cashubtc/cdk/blob/main/CODE_STYLE.md#if-let
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query the high probability routes for the public key in the invoice. Attempt the first route: if the failure code is 15 (TEMPORARY_CHANNEL_FAILURE), attempt the next route.
CHANGED
pay_invoice: forks execution based on the presence of a partial_amount.Checklist
just final-checkbefore committing