Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user PIN authentication 🔒 #104

Merged
merged 36 commits into from
Jul 9, 2023
Merged

Add user PIN authentication 🔒 #104

merged 36 commits into from
Jul 9, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Jul 7, 2023

Fixes #11

@KKA11010
begin UI for pin setup
8f54511
@KKA11010
add custom number pad UI
2b97f39
@KKA11010
fix hot reload and logging by upgrading expo SDK
fc18a9e
@KKA11010
update styling of number pads
ac1830b
@KKA11010
update auth screen. add TODOs
4fc3afa
@KKA11010
lint & fmtJson
dc0cf74
@KKA11010
update initial pin screen
8ecac7c
@KKA11010
clean up pin components
0b2e7ee
@KKA11010
setup pin, store pin hash, store locked state #11
6b3a48f
@KKA11010
rename state confirm to isConfirm
518d503
@KKA11010
fix bypassing the pin mismatch attempts
eb92f0d
@KKA11010
fix attempt and lock state while in background
b95d137
@KKA11010
update
c09dc4d
@KKA11010
check attempts stored after app restart
f88eb06
@KKA11010
avoid pin submit spam
4f337ab
@KKA11010
start pin handler on foreground after 5 mins
13851b0
@KKA11010
ask for pin if app was > 5min in bg
56c5917
@KKA11010
update auth
ca0e126
@KKA11010
add translations for auth screen
f71ba30
@KKA11010
fix TL
7f43c62
@KKA11010
add UI for PIN in settings
67c116c
@KKA11010
implement delete & edit PIN logic, see #11
cca38fc
@KKA11010
clean up
e2d1815
@KKA11010
remove logs
01571cc
@KKA11010 KKA11010 added the enhancement New feature or request label Jul 7, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Jul 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 2.51% and project coverage change: -1.76 ⚠️

Comparison is base (ae786a6) 24.30% compared to head (22f452f) 22.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   24.30%   22.54%   -1.76%     
==========================================
  Files          94       99       +5     
  Lines        3168     3424     +256     
  Branches      845      933      +88     
==========================================
+ Hits          770      772       +2     
- Misses       2333     2587     +254     
  Partials       65       65
Impacted Files Coverage Δ
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/Icons.tsx 7.62% <0.00%> (-0.41%) ⬇️
src/components/QR.tsx 20.00% <ø> (ø)
src/components/nav/Navigator.tsx 0.00% <0.00%> (ø)
src/components/nav/TopNav.tsx 0.00% <0.00%> (ø)
src/components/screens/Auth/Hint.tsx 0.00% <0.00%> (ø)
src/components/screens/Auth/PinDots.tsx 0.00% <0.00%> (ø)
src/components/screens/Auth/PinPad.tsx 0.00% <0.00%> (ø)
src/components/screens/Auth/index.tsx 0.00% <0.00%> (ø)
src/components/screens/Lightning/modal.tsx 26.73% <0.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilligsterUser
Copy link
Contributor

is this branch ready?

BilligsterUser
BilligsterUser suggested changes Jul 9, 2023
View reviewed changes
config/app.config.ts Outdated Show resolved Hide resolved
src/context/Pin.tsx Outdated Show resolved Hide resolved
BilligsterUser
BilligsterUser suggested changes Jul 9, 2023
View reviewed changes
src/components/App.tsx Outdated Show resolved Hide resolved
src/context/Pin.tsx Outdated Show resolved Hide resolved
BilligsterUser
BilligsterUser suggested changes Jul 9, 2023
View reviewed changes
src/components/App.tsx Outdated Show resolved Hide resolved
@BilligsterUser
Copy link
Contributor

i pushed a commit to use the store instead of asyncStore

BilligsterUser
BilligsterUser suggested changes Jul 9, 2023
View reviewed changes
src/components/App.tsx Outdated Show resolved Hide resolved
BilligsterUser
BilligsterUser previously approved these changes Jul 9, 2023
View reviewed changes
@BilligsterUser BilligsterUser dismissed their stale review July 9, 2023 15:14

lets wait for the ci

@KKA11010 KKA11010 merged commit 0d8becd into main Jul 9, 2023
@KKA11010 KKA11010 deleted the 11-user-authentication branch July 9, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BilligsterUser BilligsterUser BilligsterUser approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First Beta Release
Development

Successfully merging this pull request may close these issues.

User authentication
3 participants
@KKA11010 @codecov-commenter @BilligsterUser