Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update #123

Merged
merged 196 commits into from
Aug 17, 2023
Merged

Major update #123

merged 196 commits into from
Aug 17, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Aug 13, 2023

This PR brings a lot of changes in terms of UX and DX. It mostly had to be done as a huge PR due to many related components. Also I kept making changes there to provide a clean and ready PR for the main branch.

Summary of major changes:

  • NOSTR intergration for sending and receiving Ecash
  • Improved the UX for the payment related screens
  • Propose user to mint token after adding a new mint
  • Migrated changes from @BilligsterUser for Android build crash
  • Improved DX for translation namespaces
  • Improved DX with type-safe theme and color related objects
  • Added Info screens on initial app start
  • Updated SplashScreen and README image/content
  • Adapted all screen layouts for iOS
  • Updated styling of dashboard/wallet screen
  • Several bug fixes and missing translations
  • Update folder structure for components and screens
  • Cleaned up Context provider in the App.tsx file

Closed issues

  1. Fixes Improve send/receive UX #112
  2. Fixes Use device theme on initial start #105
  3. Fixes Add coin selection for inter-mint swap #5
  4. Fixes QR code can not be scanned on IOS #7

@KKA11010 KKA11010 added the enhancement New feature or request label Aug 13, 2023
@KKA11010 KKA11010 added this to the First Beta Release milestone Aug 13, 2023
@KKA11010 KKA11010 self-assigned this Aug 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Patch coverage: 3.98% and project coverage change: -7.43% ⚠️

Comparison is base (6ff878c) 22.80% compared to head (0432ca6) 15.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   22.80%   15.38%   -7.43%     
==========================================
  Files         100      137      +37     
  Lines        3451     4330     +879     
  Branches      938     1166     +228     
==========================================
- Hits          787      666     -121     
- Misses       2599     3585     +986     
- Partials       65       79      +14     
Files Changed Coverage Δ
src/components/ActionButtons.tsx 0.00% <0.00%> (ø)
src/components/App.tsx 0.00% <0.00%> (ø)
src/components/Backup.tsx 0.00% <0.00%> (ø)
src/components/Blank.tsx 0.00% <0.00%> (ø)
src/components/Button.tsx 0.00% <0.00%> (-100.00%) ⬇️
src/components/ClipboardModal.tsx 0.00% <0.00%> (ø)
src/components/Copy.tsx 0.00% <0.00%> (ø)
src/components/Empty.tsx 0.00% <0.00%> (ø)
src/components/InitialModal.tsx 0.00% <0.00%> (ø)
src/components/LeaveAppModal.tsx 0.00% <0.00%> (ø)
... and 103 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010
Copy link
Collaborator Author

KKA11010 commented Aug 13, 2023

@BilligsterUser A complete review may take around 8hrs. However you dont need to review the UI related components

Only the small amount of files I changed related to DB and CONFIG which you have created yourself would be great. Estimated 20-30mins review.

@KKA11010 KKA11010 merged commit c11757d into main Aug 17, 2023
3 checks passed
@KKA11010 KKA11010 deleted the ux branch August 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants