Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview workflow #149

Closed
wants to merge 15 commits into from
Closed

Preview workflow #149

wants to merge 15 commits into from

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Aug 27, 2023

This PR includes enhancements to both the GitHub workflows and the build scripts found in the package.json file.

As part of these changes, I'm introducing iOS builds into the workflow. Preview builds for both iOS and Android should now be generated automatically whenever a pull request is initiated against the main branch and the node.js.yml workflow does not fail. This guarantees that we can test preview builds prior to integrating any code changes into the main branch.

@KKA11010 KKA11010 added enhancement New feature or request Android Android related issues IOS IOS related issues test Test related CI CI related issue DX Topics related to developer experience labels Aug 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c1b48b) 15.01% compared to head (a84accb) 15.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   15.01%   15.01%           
=======================================
  Files         140      140           
  Lines        4508     4508           
  Branches     1219     1219           
=======================================
  Hits          677      677           
  Misses       3747     3747           
  Partials       84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010
Copy link
Collaborator Author

eas preview builds were skipped, so I have do more research and adapt accordingly.

@KKA11010 KKA11010 marked this pull request as draft August 27, 2023 13:38
@KKA11010 KKA11010 added this to the First Beta Release milestone Aug 27, 2023
@KKA11010 KKA11010 marked this pull request as ready for review August 27, 2023 14:20
@KKA11010
Copy link
Collaborator Author

I think the PR is ready

@KKA11010 KKA11010 marked this pull request as draft September 2, 2023 19:23
@KKA11010 KKA11010 removed the request for review from BilligsterUser September 2, 2023 21:24
@KKA11010 KKA11010 removed this from the First Beta Release milestone Sep 7, 2023
@KKA11010 KKA11010 closed this Nov 22, 2023
@KKA11010 KKA11010 deleted the preview branch November 22, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android related issues CI CI related issue DX Topics related to developer experience enhancement New feature or request IOS IOS related issues test Test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants