-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview workflow #149
Closed
Preview workflow #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKA11010
added
enhancement
New feature or request
Android
Android related issues
IOS
IOS related issues
test
Test related
CI
CI related issue
DX
Topics related to developer experience
labels
Aug 27, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 15.01% 15.01%
=======================================
Files 140 140
Lines 4508 4508
Branches 1219 1219
=======================================
Hits 677 677
Misses 3747 3747
Partials 84 84 ☔ View full report in Codecov by Sentry. |
eas preview builds were skipped, so I have do more research and adapt accordingly. |
I think the PR is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes enhancements to both the GitHub workflows and the build scripts found in the
package.json
file.As part of these changes, I'm introducing iOS builds into the workflow. Preview builds for both iOS and Android should now be generated automatically whenever a pull request is initiated against the
main
branch and thenode.js.yml
workflow does not fail. This guarantees that we can test preview builds prior to integrating any code changes into themain
branch.