Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX while scanning token and claiming after app comes to foreground #221

Merged
merged 8 commits into from
Sep 16, 2023

Conversation

KKA11010
Copy link
Collaborator

  • The success screen is now shown after successful scanning a token and after app comes to the foreground.
  • If app comes to the foreground and the PIN screen is displayed (>5min inactivity) the success screen takes to back to the PIN screen

@KKA11010 KKA11010 added the bug Something isn't working label Sep 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.91% 🎉

Comparison is base (1c8d0c9) 14.73% compared to head (6f1dc87) 15.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   14.73%   15.64%   +0.91%     
==========================================
  Files         141      141              
  Lines        4601     4614      +13     
  Branches     1253     1255       +2     
==========================================
+ Hits          678      722      +44     
+ Misses       3837     3808      -29     
+ Partials       86       84       -2     
Files Changed Coverage Δ
src/components/App.tsx 0.00% <ø> (ø)
src/components/modal/TrustMint.tsx 0.00% <0.00%> (ø)
src/components/nav/utils.ts 0.00% <0.00%> (ø)
src/context/FocusClaim.tsx 5.71% <0.00%> (+5.71%) ⬆️
src/screens/Dashboard.tsx 0.00% <0.00%> (ø)
src/screens/Payment/Receive/Invoice.tsx 0.00% <ø> (ø)
src/screens/Payment/Success.tsx 0.00% <0.00%> (ø)
src/screens/QRScan/index.tsx 0.00% <0.00%> (ø)
src/components/Balance.tsx 62.50% <75.00%> (+4.00%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 merged commit f5b152e into main Sep 16, 2023
5 checks passed
@KKA11010 KKA11010 deleted the 0.0.4 branch September 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants