Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0-beta #276

Merged
merged 57 commits into from
Dec 7, 2023
Merged

0.2.0-beta #276

merged 57 commits into from
Dec 7, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Dec 5, 2023

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (c9b3cd1) 13.60% compared to head (2097e19) 13.48%.

Files Patch % Lines
src/components/animation/QrTransition.ts 0.00% 38 Missing and 1 partial ⚠️
src/screens/Dashboard.tsx 0.00% 16 Missing ⚠️
src/components/nav/BottomNav.tsx 0.00% 13 Missing ⚠️
src/screens/Payment/Success.tsx 0.00% 6 Missing ⚠️
src/screens/Settings/General/index.tsx 0.00% 6 Missing ⚠️
src/screens/Payment/Processing.tsx 0.00% 5 Missing ⚠️
src/screens/History/Entry.tsx 0.00% 3 Missing ⚠️
src/screens/QRScan/index.tsx 0.00% 2 Missing ⚠️
src/screens/Mints/Proofs.tsx 0.00% 1 Missing ⚠️
src/screens/Payment/SelectNostrAmount.tsx 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   13.60%   13.48%   -0.13%     
==========================================
  Files         161      162       +1     
  Lines        5838     5890      +52     
  Branches     1603     1620      +17     
==========================================
  Hits          794      794              
- Misses       4900     4951      +51     
- Partials      144      145       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few strings in the app I found "untranslateable". Is it possible to add these too?
"Wallet" on main screen
"Proofs" in Settings -> Manage Mints -> select mint -> Funds

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few strings in the app I found "untranslateable". Is it possible to add these too? "Wallet" on main screen "Proofs" in Settings -> Manage Mints -> select mint -> Funds

Thank you for your review sir, really appreciate it! Yes, you are right, I will add these as well.
How should I translate "wallet" and "proofs"?

I've also had to add new translations due to new screens. I used chatGPT for it, can you please review those as well? You can find them for hungarian here line 227 to 234

@KvartBeerborn for spanish here line 227 to 234

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!
"wallet" should be "tárca" and
"proofs" should be "bizonylatok"

@KKA11010 KKA11010 removed the request for review from BilligsterUser December 6, 2023 14:01
Copy link
Collaborator

@onoomobo onoomobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK! 👍

@KKA11010 KKA11010 merged commit e83703a into main Dec 7, 2023
5 checks passed
@KKA11010 KKA11010 deleted the 0.1.3-beta branch December 7, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants