Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for bug in auto mint swap #278

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Patch for bug in auto mint swap #278

merged 4 commits into from
Dec 11, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Dec 8, 2023

  • This PR patches the wrong fee estimation caused by requesting fees from destination mint rather than source mint.
  • It also fixes the nav UI on ios and the additional space in the bottom of the contacts screen

Fixes #279

@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (70a5f54) 13.47% compared to head (bb61ef3) 13.47%.

Files Patch % Lines
src/screens/Payment/Success.tsx 0.00% 4 Missing ⚠️
src/wallet/index.ts 0.00% 4 Missing ⚠️
src/screens/Payment/Processing.tsx 0.00% 3 Missing ⚠️
src/components/nav/BottomNav.tsx 0.00% 1 Missing ⚠️
src/screens/Addressbook/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   13.47%   13.47%   -0.01%     
==========================================
  Files         162      162              
  Lines        5891     5893       +2     
  Branches     1620     1622       +2     
==========================================
  Hits          794      794              
- Misses       4952     4954       +2     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 merged commit a89a519 into main Dec 11, 2023
5 checks passed
@KKA11010 KKA11010 deleted the patch branch December 11, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoswap does not work
2 participants