Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.2-beta patch #287

Merged
merged 13 commits into from
Feb 8, 2024
Merged

0.2.2-beta patch #287

merged 13 commits into from
Feb 8, 2024

Conversation

KKA11010
Copy link
Collaborator

  • Fixes UI: Buggy Navbar behavior when adding Npub #285
  • Improve UX while scanning Ecash QR code displayed in the history entry details
  • Improve UI of bottom sheets for send/receive/trust-mint sheets according to review
  • Update to expo compatible dependencies

@KKA11010
Copy link
Collaborator Author

@swedishfrenchpress fixed some minor styling issues. You can run and test this branch patch.

If you have noticed other minor UI issues, please let me know and I will include the fix in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (d503c80) 13.47% compared to head (3fca873) 13.38%.

Files Patch % Lines
src/screens/History/Details.tsx 0.00% 22 Missing ⚠️
src/components/nav/BottomNav.tsx 0.00% 13 Missing ⚠️
src/components/modal/OptsModal.tsx 0.00% 9 Missing ⚠️
src/components/modal/TrustMint.tsx 0.00% 7 Missing ⚠️
src/context/Release.tsx 0.00% 7 Missing ⚠️
src/screens/Settings/index.tsx 0.00% 6 Missing ⚠️
src/screens/Auth/PinPad.tsx 0.00% 4 Missing ⚠️
src/screens/Auth/index.tsx 0.00% 4 Missing ⚠️
src/screens/Payment/ProcessingError.tsx 0.00% 4 Missing ⚠️
src/components/Icons.tsx 0.00% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   13.47%   13.38%   -0.10%     
==========================================
  Files         162      162              
  Lines        5893     5934      +41     
  Branches     1624     1639      +15     
==========================================
  Hits          794      794              
- Misses       4954     4995      +41     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 merged commit 6791b83 into main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Buggy Navbar behavior when adding Npub
2 participants