Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History migration from keyValueStore to sqlite #290

Closed
wants to merge 32 commits into from
Closed

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Dec 26, 2023

  • Add pending history entries for minting-invoices Fixes Mint invoice is lost after going back without paying #245
  • Handle pending minting-invoices
  • Improve UX by replacing requestTokenLoop with interval in global context
  • Improve history queries by migrating data from native key-value store to sqlite table
  • Add basic tests for sqlite transactions table queries (history)
  • Add balance counter animation

@codecov-commenter
Copy link

Codecov Report

Attention: 176 lines in your changes are missing coverage. Please review.

Comparison is base (3fca873) 13.38% compared to head (2b96025) 13.86%.

Files Patch % Lines
src/context/History.tsx 5.26% 72 Missing ⚠️
src/screens/Payment/Receive/Invoice.tsx 0.00% 18 Missing ⚠️
src/screens/History/Details.tsx 0.00% 13 Missing ⚠️
src/context/Balance.tsx 25.00% 12 Missing ⚠️
src/storage/db/index.ts 74.35% 9 Missing and 1 partial ⚠️
src/components/Balance.tsx 52.63% 9 Missing ⚠️
src/storage/store/latestHistoryEntries.ts 14.28% 5 Missing and 1 partial ⚠️
src/screens/Dashboard.tsx 0.00% 5 Missing ⚠️
src/screens/History/Entry.tsx 0.00% 5 Missing ⚠️
src/screens/Payment/Processing.tsx 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##            patch     #290      +/-   ##
==========================================
+ Coverage   13.38%   13.86%   +0.48%     
==========================================
  Files         162      164       +2     
  Lines        5934     6038     +104     
  Branches     1639     1657      +18     
==========================================
+ Hits          794      837      +43     
- Misses       4995     5059      +64     
+ Partials      145      142       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 changed the title 0.3.0-beta History migration from keyValueStore to sqlite Mar 2, 2024
@KKA11010
Copy link
Collaborator Author

KKA11010 commented Apr 7, 2024

closed due to new PR #339

@KKA11010 KKA11010 closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants