Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hu strings in #300 #301

Closed
wants to merge 0 commits into from
Closed

Fixed hu strings in #300 #301

wants to merge 0 commits into from

Conversation

onoomobo
Copy link
Collaborator

@onoomobo onoomobo commented Feb 6, 2024

Reviewed and fixed GPT wordings in new strings.

@codecov-commenter
Copy link

Codecov Report

Attention: 500 lines in your changes are missing coverage. Please review.

Comparison is base (d503c80) 13.47% compared to head (11323cb) 13.25%.

Files Patch % Lines
src/wallet/index.ts 13.13% 72 Missing and 14 partials ⚠️
src/components/hooks/Restore.tsx 0.00% 66 Missing ⚠️
src/screens/Restore/SelectRecoveryMint.tsx 0.00% 55 Missing ⚠️
src/screens/Restore/ConfirmMnemonic.tsx 0.00% 37 Missing ⚠️
src/screens/Restore/Seed.tsx 0.00% 29 Missing ⚠️
src/screens/Restore/Mnemonic.tsx 0.00% 26 Missing ⚠️
src/screens/History/Details.tsx 0.00% 23 Missing ⚠️
src/screens/Restore/Recover.tsx 0.00% 22 Missing ⚠️
src/components/Icons.tsx 0.00% 15 Missing ⚠️
src/screens/Settings/Security.tsx 0.00% 15 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   13.47%   13.25%   -0.22%     
==========================================
  Files         162      167       +5     
  Lines        5893     6164     +271     
  Branches     1624     1687      +63     
==========================================
+ Hits          794      817      +23     
- Misses       4954     5200     +246     
- Partials      145      147       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010
Copy link
Collaborator

KKA11010 commented Feb 6, 2024

Thank you! 👍

@KKA11010
Copy link
Collaborator

KKA11010 commented Feb 8, 2024

@viragur can you rebase your branch please? I've just merged the seed PR which results in conflicts in this PR.

@onoomobo onoomobo closed this Feb 9, 2024
@onoomobo
Copy link
Collaborator Author

onoomobo commented Feb 9, 2024

@KKA11010 I think I have it 👉 👈 can you merge it?

@KKA11010
Copy link
Collaborator

KKA11010 commented Feb 9, 2024

@KKA11010 I think I have it 👉 👈 can you merge it?

It is closed. Maybe you want to create a new one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants