Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoded LNURL support #310

Closed
wants to merge 3 commits into from
Closed

Add encoded LNURL support #310

wants to merge 3 commits into from

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Feb 29, 2024

  • Renamed isLnurl to isLnurlAddress

[x] Added lib nbd-wtf/js-lnurl
[x] Added bech32-encoded lnurl utils file
[x] Detect encoded lnurl in QR code
[ ] Detect lnurl in input field
[ ] Handle decoded lnurl
[ ] Update UI

Fixes #248

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 13.14%. Comparing base (5fc6562) to head (4214a59).

Files Patch % Lines
src/util/lnurl.ts 0.00% 8 Missing ⚠️
src/screens/Payment/Send/Inputfield.tsx 0.00% 2 Missing ⚠️
src/screens/QRScan/index.tsx 0.00% 2 Missing ⚠️
src/screens/Payment/Processing.tsx 0.00% 1 Missing ⚠️
src/screens/Payment/Send/CoinSelection.tsx 0.00% 1 Missing ⚠️
src/util/index.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   13.16%   13.14%   -0.03%     
==========================================
  Files         167      168       +1     
  Lines        6214     6224      +10     
  Branches     1702     1704       +2     
==========================================
  Hits          818      818              
- Misses       5249     5259      +10     
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 closed this Mar 25, 2024
@KKA11010 KKA11010 deleted the lnurl branch March 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR code scanner does not recognize LNURL
2 participants