Keyset ID V2 #182
Open
Keyset ID V2 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Oct 30, 2024
Comment on lines
+80
to
+81
| keyset_id_bytes = b"".join([p.serialize() for p in sorted_keys.values()]) | ||
| keyset_id_bytes += b"unit:sat" |
There was a problem hiding this comment.
I am wondering ... since we already depend for CBOR (for Token v4), maybe we can use CBOR here too instead of this custom serialization?
There was a problem hiding this comment.
What would the structure of the CBOR be?
prusnak
reviewed
Oct 30, 2024
|
Thank you! Please:
|
ok300
reviewed
Nov 5, 2024
ok300
reviewed
Nov 5, 2024
| def derive_keyset_id(keys: Dict[int, PublicKey]) -> str: | ||
| sorted_keys = dict(sorted(keys.items())) | ||
| keyset_id_bytes = b"".join([p.serialize() for p in sorted_keys.values()]) | ||
| keyset_id_bytes += b"unit:sat" |
There was a problem hiding this comment.
Once optimization could be to change b"unit:sat" -> b"u:sat" or even just b"sat".
(Edit: nevermind that, it will all be hashed in the end, so reducing the length of what's inside won't matter)
Might also be worth specifying the unit should be lowercased first.
There was a problem hiding this comment.
I don't think we have specified the units as case-insensitive yet. We should probably also do that if we include this change, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new keyset ID version that commits to the keyset's unit and avoids keyset ambiguity between mints. Keyset IDs are now 33 bytes, with a one-byte version prefix before a 32-byte SHA256 hash.
Tokens maintain the same length by abbreviating the 33-byte keyset ID to the first 8 bytes: a one-byte version prefix before the first 7 bytes of the 32-byte SHA256 hash. While unlikely in practice, implementors should ensure that token keyset IDs are unambiguous to the mint when serializing.
Wallets will be responsible for expanding the abbreviated keyset ID to the full-length keyset ID.
It is now recommended to store the entire 33-byte keyset ID in a wallet's proof database.