[Mint]: refactor mint statup connection #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 69.62% 67.71% -1.92%
==========================================
Files 76 81 +5
Lines 6913 7337 +424
==========================================
+ Hits 4813 4968 +155
- Misses 2100 2369 +269 ☔ View full report in Codecov by Sentry. |
callebtc
requested changes
Jun 26, 2024
| await migrate_databases(ledger.db, migrations) | ||
| await ledger.startup_ledger() | ||
| logger.info("Mint started.") | ||
| except: |
There was a problem hiding this comment.
Could you also print the Exception e, and use logger.error()?
Suggested change
| except: | |
| except Exception as e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #518