Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: Add clnrest.py Lightning backend #551

Merged
merged 32 commits into from
Jun 30, 2024

Conversation

lollerfirst
Copy link
Contributor

@lollerfirst lollerfirst commented Jun 16, 2024

@lollerfirst
Copy link
Contributor Author

lollerfirst commented Jun 27, 2024

I fixed and merged @rbensberg branch which puts corelightningrest.py onto the newer plugin clnrest which comes integrated with CLN and should just work without too many hoops.

Although NOW for some reason it hangs when verifying the payment of the quote (when minting tokens). If you stop it and then check the invoice manually cashu invoice <amount> --id <quote_id> it updates correctly.

Not quite sure what's causing this.

@lollerfirst
Copy link
Contributor Author

lollerfirst commented Jun 28, 2024

paid_invoices_stream was the problem. Fixed it.

@callebtc
Copy link
Collaborator

Thank you for the fixes in lndrest.py. Could you put those changes into a separate PR?

@lollerfirst
Copy link
Contributor Author

Yea sure.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 11.47541% with 54 lines in your changes missing coverage. Please review.

Project coverage is 64.90%. Comparing base (1766b6e) to head (6716256).
Report is 5 commits behind head on main.

Current head 6716256 differs from pull request most recent head c788b74

Please upload reports for the commit c788b74 to get more accurate results.

Files Patch % Lines
cashu/lightning/corelightningrest.py 4.34% 44 Missing ⚠️
cashu/lightning/lndrest.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   65.02%   64.90%   -0.12%     
==========================================
  Files          91       91              
  Lines        8065     8147      +82     
==========================================
+ Hits         5244     5288      +44     
- Misses       2821     2859      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc changed the title Feature: CoreLightningRest partial payouts Mint: Add clnrest.py Lightning backend Jun 30, 2024
@callebtc callebtc merged commit ca272bc into cashubtc:main Jun 30, 2024
11 checks passed
@lollerfirst lollerfirst deleted the cln-partial-payments branch July 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants