Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: LNbitsWallet add extra check for payment state #601

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Jul 26, 2024

Needs testing:

  • mint with lnbits backend with lnd backend
  • create melt quote
  • turn off lnd
  • try melting
  • melt should fail

@minibits-cash
Copy link

PR tested using test mint. My test mint does not use LND but LNbits with Fakewallet.

  1. Test with melt while LNbits running - OK
  2. Test with melt while LNbits turned off - mint returned error:
return PaymentResponse(error_message=r.json()["detail"])
UnboundLocalError: local variable 'r' referenced before assignment"

When looking at the code "r" seems to be defined only inside of try block, so not available in catch block to return proper error message?

@callebtc callebtc merged commit 48b0368 into main Oct 28, 2024
18 checks passed
@callebtc callebtc deleted the fix-lnbits-stuck-melt branch October 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants