-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait for uvicorn server to bind before running tests #607
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had a simple `time.sleep(1)` call after `server.start()` which was present to give the Mint's HTTP server time to spin up during test runs. This meant that if the server took longer than 1s to start on a dev's machine for any reason (even intermittently) then tests would fail due to connection errors. The fix is to use a simple repeated polling check which allows the test runner to start only once the server is confirmed listening.
conduition
force-pushed
the
fix-test-sleep
branch
from
August 1, 2024 15:38
ae2b1e9
to
2e58fe6
Compare
Fixed an infinite loop bug. Tests now pass on my machine |
Correction: a couple of tests are still failing.
And
These failures don't seem to be related to this PR. |
prusnak
suggested changes
Sep 8, 2024
Co-authored-by: Pavol Rusnak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a simple
time.sleep(1)
call afterserver.start()
which was present to give the Mint's HTTP server time to spin up during test runs. This meant that if the server took longer than 1s to start on a dev's machine for any reason (even intermittently) then tests would fail due to connection errors.The fix is to use a simple repeated polling check which allows the test runner to start only once the server is confirmed listening.
Drive-by: remove an unnecessary duplicate
settings.mint_host
assignment to the 'all interfaces' IP0.0.0.0
.