feat: use unstructured runtime objects instead of Karpenter types #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pijusn-cast
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
vladklokun,
linkas45,
laimonasr and
kasia-kujawa
as code owners
saumas
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is basically a recently reverted change except that the issue with
PodMetricsobject kind was fixed (error was here). Also note that currently,mainbranch has a new unit test to add secondary verification for this kind of error (and I checked that it does fail with the original change).I tested this agent build manually to confirm it includes objects with
kind=PodMetricsin the snapshot deltas. It seems to work.