feat: store cluster id in a metadata secret #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laimonasr
requested review from
saumas,
mindaugasCast,
dariuspie,
zilvinasu,
KarolisL,
mikenorgate,
jakubsolecki,
pijusn-cast,
vladklokun,
linkas45 and
kasia-kujawa
as code owners
laimonasr
force-pushed
the
store-metadata-in-secret
branch
from
8d37568 to
d8da567
Compare
KarolisL
reviewed
Dec 5, 2024
internal/services/metadata/store.go
Outdated
| return nil | ||
| } | ||
|
|
||
| secret := &corev1.Secret{ |
There was a problem hiding this comment.
Do we plan storing any sensitive data here? If not, maybe it would be better to use configMap instead: it is easier to inspect the values with kubectl get cm -o yaml since you don't need to decode the b64.
There was a problem hiding this comment.
Currently there are no plans to store sensitive data and I agree that config map seems like a better store in that case. Cluster id is intended to be used by cluster controller, which currently only supports loading it from a secret and not from a config map that's why I'm storing it in a secret instead
laimonasr
force-pushed
the
store-metadata-in-secret
branch
2 times, most recently
from
43319a7 to
08bdf35
Compare
laimonasr
force-pushed
the
store-metadata-in-secret
branch
from
08bdf35 to
1f81167
Compare
KarolisL
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.