Do not report container stats for muted namespaces

castai · Mar 12, 2024 · 577fb7a · 577fb7a
1 parent 30bc53c
commit 577fb7a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/cmd/agent/daemon/state/container_stats_pipeline.go b/cmd/agent/daemon/state/container_stats_pipeline.go
@@ -88,6 +88,10 @@ func (c *Controller) scrapeContainersResourceStats(batch *castpb.ContainerStatsB
 			continue
 		}
 
+		if c.IsMutedNamespace(cont.PodNamespace) {
+			continue
+		}
+
 		now := time.Now().UTC()
 		cpu, err := cont.Cgroup.CpuStat()
 		if err != nil {
@@ -234,6 +238,10 @@ func (c *Controller) scrapeContainersSyscallStats(ctx context.Context, batch *ca
 			continue
 		}
 
+		if c.IsMutedNamespace(cont.PodNamespace) {
+			continue
+		}
+
 		// We need at least 2 scrapes to calculate diff count.
 		c.syscallScrapePointsMu.RLock()
 		prevScrape, found := c.syscallScrapePoints[cont.CgroupID]

diff --git a/cmd/agent/daemon/state/controller.go b/cmd/agent/daemon/state/controller.go
@@ -118,11 +118,7 @@ func (c *Controller) Run(ctx context.Context) error {
 }
 
 func (c *Controller) onNewContainer(container *containers.Container) {
-	c.mutedNamespacesMu.RLock()
-	_, muted := c.mutedNamespaces[container.PodNamespace]
-	c.mutedNamespacesMu.RUnlock()
-
-	if !muted {
+	if !c.IsMutedNamespace(container.PodNamespace) {
 		return
 	}
 
@@ -202,3 +198,11 @@ func (c *Controller) UnmuteNamespace(namespace string) error {
 
 	return nil
 }
+
+func (c *Controller) IsMutedNamespace(namespace string) bool {
+	c.mutedNamespacesMu.RLock()
+	defer c.mutedNamespacesMu.RUnlock()
+	_, found := c.mutedNamespaces[namespace]
+
+	return found
+}