feat: reliable finale generation, stubbed in existing rarer buildings for finales #9177
Annotations
11 warnings
|
Post checkout repository
The process '/usr/bin/git' failed with exit code 128
|
|
run clang-tidy:
src/weather.cpp#L501
return statement within a void function should not have a specified return value [readability-avoid-return-with-void-value]
|
|
run clang-tidy:
src/weather.cpp#L505
return statement within a void function should not have a specified return value [readability-avoid-return-with-void-value]
|
|
run clang-tidy:
src/weather.cpp#L510
return statement within a void function should not have a specified return value [readability-avoid-return-with-void-value]
|
|
run clang-tidy:
src/overmap.cpp#L2844
conversion from 'std::optional<string_id<overmap_special>>' into 'string_id<overmap_special>' and back into 'std::optional<string_id<overmap_special>>', remove potentially error-prone optional dereference [bugprone-optional-value-conversion]
|
|
run clang-tidy:
src/overmap.cpp#L3298
1st argument 'extra_text' (passed to 'text') looks like it might be swapped with the 2nd, 'text' (passed to 'filter') [readability-suspicious-call-argument]
|
|
run clang-tidy:
src/overmap.cpp#L5652
an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
|
|
run clang-tidy:
src/overmap.cpp#L5669
an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]
|
|
run clang-tidy:
src/panels.cpp#L297
Prefer constructing 'point' from named constant 'point_north_west' rather than explicit integer arguments. [cata-use-named-point-constants]
|
|
run clang-tidy:
src/panels.cpp#L1805
'wedge_range' defines fields 'x0' and 'y0'. Consider combining into a single point field. [cata-xy]
|
|
run clang-tidy:
src/panels.cpp#L1805
'wedge_range' defines fields 'x1' and 'y1'. Consider combining into a single point field. [cata-xy]
|
Loading