Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stagger item categories for modder support #5889

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

RoyalFox2140
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 commented Jan 6, 2025

Checklist

Required

Purpose of change

We don't want stuff to overlap. Item categories were all 1 after the other. Modders couldn't put stuff where they want.

Describe the solution

I staggered every category by 3. Now you get 2 categories to inject between any other. Nothing changed under the hood

Mods can fight if they want, I'm not a cop but maybe try not to use categories unless you have to.

Describe alternatives you've considered

Suffering. Making others suffer by figuring out a code-based solution that lets users sort categories themselves.

Testing

image
image
image

Additional context

Someone should code it so users can organize their own categories, but I can't.

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jan 6, 2025
Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice improved mod support.

@RoyalFox2140 RoyalFox2140 merged commit 61cba34 into cataclysmbnteam:main Jan 6, 2025
13 checks passed
@RoyalFox2140 RoyalFox2140 deleted the stagger branch January 6, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants