Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WIP draft of diverse filetypes lesson #2

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

e-belfer
Copy link
Member

Overview

What problem does this address?
Adds the first skeleton of the "reading in diverse filetypes" lesson.

What did you change in this PR?
Added draft key objectives, questions and key points.

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

Tasks

Preview Give feedback

@e-belfer e-belfer requested a review from jdangerx October 24, 2024 19:52
@e-belfer e-belfer self-assigned this Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/catalyst-cooperative/open-energy-data-for-all/compare/md-outputs..md-outputs-PR-2

The following changes were observed in the rendered markdown documents:

 config.yaml                             |  1 +
 md5sum.txt                              |  3 ++-
 working-with-diverse-filetypes.md (new) | 31 +++++++++++++++++++++++++++++++
 3 files changed, 34 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-24 19:55:20 +0000

github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
Copy link
Member

@jdangerx jdangerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢, we should potentially talk about how many colons to use for the fenced blocks

@@ -0,0 +1,31 @@
---
title: "Handling diverse filetypes in Pandas"
teaching: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They said to set this to 0!

github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
@e-belfer e-belfer merged commit 2e08a71 into main Oct 24, 2024
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
Auto-generated via `{sandpaper}`
Source  : 2e08a71
Branch  : main
Author  : E. Belfer <[email protected]>
Time    : 2024-10-24 19:58:54 +0000
Message : Merge pull request #2 from catalyst-cooperative/add-read-in-lesson

Add WIP draft of diverse filetypes lesson
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
Auto-generated via `{sandpaper}`
Source  : 6e8090a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-24 19:59:30 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 2e08a71
Branch  : main
Author  : E. Belfer <[email protected]>
Time    : 2024-10-24 19:58:54 +0000
Message : Merge pull request #2 from catalyst-cooperative/add-read-in-lesson

Add WIP draft of diverse filetypes lesson
e-belfer added a commit that referenced this pull request Jan 16, 2025
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
Auto-generated via `{sandpaper}`
Source  : 0252077
Branch  : main
Author  : E. Belfer <[email protected]>
Time    : 2025-01-16 14:36:22 +0000
Message : Merge pull request #15 from catalyst-cooperative/diverse-filetypes

First complete draft of episode #2
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
Auto-generated via `{sandpaper}`
Source  : 1e0f801
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2025-01-16 14:37:13 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 0252077
Branch  : main
Author  : E. Belfer <[email protected]>
Time    : 2025-01-16 14:36:22 +0000
Message : Merge pull request #15 from catalyst-cooperative/diverse-filetypes

First complete draft of episode #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants