Fix quoting error in workflow file #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
added
bug
zaneselvans
commented
Nov 1, 2024
| @@ -6,7 +6,7 @@ on: | |||
| inputs: | |||
| datasets: | |||
| description: 'Comma-separated list of datasets to archive (e.g., "ferc2","ferc6").' | |||
| default: '"eia176","eia191","eia757a","eia860","eia860m","eia861","eia923","eia930","eiaaeo","eiawater","eia_bulk_elec","epacamd_eia","epacems",ferc1","ferc2","ferc6","ferc60","ferc714","mshamines","nrelatb","phmsagas","vcerare"' | |||
| default: '"eia176","eia191","eia757a","eia860","eia860m","eia861","eia923","eia930","eiaaeo","eiawater","eia_bulk_elec","epacamd_eia","epacems","ferc1","ferc2","ferc6","ferc60","ferc714","mshamines","nrelatb","phmsagas","vcerare"' | |||
There was a problem hiding this comment.
Not sure how I did it, but this one character error was my fault. Introduced when I switched us off the bigger paid runner.
There was a problem hiding this comment.
And it doesn't get caught by the action linter because it's an error in our little JSON blob.
There was a problem hiding this comment.
Ugh. Slipped past both of us. Well, at least you caught it now!
jdangerx
approved these changes
Nov 1, 2024
| @@ -6,7 +6,7 @@ on: | |||
| inputs: | |||
| datasets: | |||
| description: 'Comma-separated list of datasets to archive (e.g., "ferc2","ferc6").' | |||
| default: '"eia176","eia191","eia757a","eia860","eia860m","eia861","eia923","eia930","eiaaeo","eiawater","eia_bulk_elec","epacamd_eia","epacems",ferc1","ferc2","ferc6","ferc60","ferc714","mshamines","nrelatb","phmsagas","vcerare"' | |||
| default: '"eia176","eia191","eia757a","eia860","eia860m","eia861","eia923","eia930","eiaaeo","eiawater","eia_bulk_elec","epacamd_eia","epacems","ferc1","ferc2","ferc6","ferc60","ferc714","mshamines","nrelatb","phmsagas","vcerare"' | |||
There was a problem hiding this comment.
Ugh. Slipped past both of us. Well, at least you caught it now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There was a syntax error in the JSON that we feed into the monthly archive script as a matrix and so it failed to run November 1st. This PR literally adds a single character to that JSON blob to double-quote
"ferc1".Testing
I've kicked off a
workflow_dispatchrun manually it seems to be running as expected.