Skip to content

Commit

Permalink
ensure all the corrections get tags and add the begining of a rate ba…
Browse files Browse the repository at this point in the history
…se asset (#3214)

* ensure all the corrections get tags and add the begining of a rate base asset

* Add in cash on hand as an additional factoid into rate base table

* add documentation for rate base table

* remove _correction record from the expense.

the correction corrects the calculations of the parent
(operating expense) and its child subcomponents. if we were calculating
the expense i would want to include the correction but i don't want it if
we are just grabbing the reported value

* attempt to associate tags with _correction factoids when all child calc componets have same tags

* Add a simple XbrlCalculationForest test.

Just see if we can get an annotated forest at all right now. TODO: test for tag propagation behavior.

Co-authored-by: Christina Gosnell <[email protected]>

* WIP: write down some to-dos for test cases.

* Get leafward propagation working

* first pass of adding leafward tags one layer and an attempt at a recursive method

* integrate the recursive tag propagation method

* remove old correction tagging and standardize unit tests a bit

* remove metadata from forest builder and cleanup unit tests

* add "validation" checks and standardize null tag behavior`

* light cleaning

* root boose docs!

Co-authored-by: Dazhong Xia <[email protected]>

* respond to dazhong's comments

* add a test about pruned nodes and add the NodeId(*n) into the orphans

---------

Co-authored-by: Dazhong Xia <[email protected]>
Co-authored-by: Christina Gosnell <[email protected]>
  • Loading branch information
3 people authored Feb 2, 2024
1 parent bfe44b5 commit 7d2b312
Show file tree
Hide file tree
Showing 3 changed files with 630 additions and 112 deletions.
Loading

0 comments on commit 7d2b312

Please sign in to comment.