-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eia861 2022 #2782
Eia861 2022 #2782
Conversation
I think you'll have to add
|
…add the encoding step so the code_fixes get applied and the foreign key error isn't tripped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming the CI passes successfully -- we should look at some of the stuff that's downstream too, like the service territory tables.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #2782 +/- ##
=====================================
Coverage 88.3% 88.4%
=====================================
Files 89 90 +1
Lines 10206 10193 -13
=====================================
- Hits 9021 9016 -5
+ Misses 1185 1177 -8
☔ View full report in Codecov by Sentry. |
This PR adds in EIA861 early release data.
The only quirks were that the directory name was different from the zipfile name, so the file_map includes a prefix of
f8612022er/
for each of the files, and a change in skip rows for the reliability table in 2021. It also adds an encoding step for the reliability table to avoid foreign key failures.The former might change for the regular release data. See issue #2780 (linked)
There are no tests for 861 so that's all we've got.