Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply naming convention to output assets #2791

Closed
wants to merge 1 commit into from
Closed

Conversation

bendnorman
Copy link
Member

@bendnorman bendnorman commented Aug 16, 2023

PR Overview

This applies the new naming conventions to output assets and prunes some output tables in the database.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bendnorman bendnorman marked this pull request as draft August 16, 2023 17:51
@bendnorman bendnorman linked an issue Aug 16, 2023 that may be closed by this pull request
Base automatically changed from rename-non-db-assets to dev August 17, 2023 20:21
@bendnorman bendnorman self-assigned this Aug 28, 2023
@bendnorman
Copy link
Member Author

Closing this in favor of creating smaller PRs to be merged into #2818.

output_asset_aggregations.ipynb is on the resolve-eia-denorm-assets branch.

@bendnorman bendnorman closed this Sep 18, 2023
@bendnorman bendnorman deleted the rename-output-assets branch September 18, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant