-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inter-table 1:1 dimensions in calculations for XBRL explosion #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
force-pushed
the
explode_calc_fixes
branch
from
September 25, 2023 21:31
fd10d21
to
8c15d79
Compare
e-belfer
changed the base branch from
explode_standardize_total_to_subdim_calc_checks
to
dev
September 25, 2023 21:32
e-belfer
changed the title
Fix inter-table calculations for XBRL explosion
Fix inter-table 1:1 dimensions in calculations for XBRL explosion
Sep 25, 2023
e-belfer
force-pushed
the
explode_calc_fixes
branch
from
September 25, 2023 22:05
1ae2d4d
to
05b2c4d
Compare
zaneselvans
approved these changes
Sep 25, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2890 +/- ##
=====================================
Coverage 88.5% 88.5%
=====================================
Files 90 90
Lines 10805 10805
=====================================
Hits 9573 9573
Misses 1232 1232 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2703 for detailed issue tracking. We have inter-table calcs that are not very correct. Let's get them down to an acceptable threshold of correctness. This issue tackles a first subset of issues by specifying
utility_type
for 1:1 linkages between tables.Note that #2810 will add a whole bunch of
totals
dimensions where they don't currently exist, so this fix may need to be extended into other dimensions.PR Checklist
dev
).