Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inter-table 1:1 dimensions in calculations for XBRL explosion #2890

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

e-belfer
Copy link
Member

@e-belfer e-belfer commented Sep 25, 2023

See #2703 for detailed issue tracking. We have inter-table calcs that are not very correct. Let's get them down to an acceptable threshold of correctness. This issue tackles a first subset of issues by specifying utility_type for 1:1 linkages between tables.

Note that #2810 will add a whole bunch of totals dimensions where they don't currently exist, so this fix may need to be extended into other dimensions.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

@e-belfer e-belfer self-assigned this Sep 25, 2023
@e-belfer e-belfer added rmi xbrl Related to the FERC XBRL transition labels Sep 25, 2023
@e-belfer e-belfer changed the base branch from explode_standardize_total_to_subdim_calc_checks to dev September 25, 2023 21:32
@e-belfer e-belfer marked this pull request as ready for review September 25, 2023 21:42
@e-belfer e-belfer changed the title Fix inter-table calculations for XBRL explosion Fix inter-table 1:1 dimensions in calculations for XBRL explosion Sep 25, 2023
@e-belfer e-belfer marked this pull request as draft September 25, 2023 21:53
@e-belfer e-belfer changed the base branch from dev to explode_calc_standardization September 25, 2023 22:06
@e-belfer e-belfer marked this pull request as ready for review September 25, 2023 22:20
Base automatically changed from explode_calc_standardization to dev September 25, 2023 23:11
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (80035d1) 88.5% compared to head (3e98da2) 88.5%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2890   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files         90      90           
  Lines      10805   10805           
=====================================
  Hits        9573    9573           
  Misses      1232    1232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans merged commit 061834a into dev Sep 25, 2023
9 checks passed
@zaneselvans zaneselvans deleted the explode_calc_fixes branch September 25, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rmi xbrl Related to the FERC XBRL transition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Check and debug inter-table and inter-dimensional calculations for both exploded tables
3 participants