Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ferc-ferc plant matching with ccai implementation. #3007
Update ferc-ferc plant matching with ccai implementation. #3007
Changes from 83 commits
6c8a86d
a57810a
688b577
1878348
e7686c3
e526516
4b5bea4
4ccdcc6
586b973
f5e4f14
3026681
be7f28d
211ff32
a77c7d7
778d059
44f2fd0
b76f2d2
54cb3ca
ead2c8e
fdfe1c2
4190361
ecd84ca
0921557
305411e
8694279
43c51e1
e6df48e
ffcdc1e
fd58293
361162c
7026784
1e6e8e8
ab95188
8aba02b
50d1f98
6190584
7abd6bd
25a533d
5e109f6
152e776
ea643bd
99ec8ee
7e7affc
5757f44
7b356e8
6f2b787
c2ea24a
3ec367d
8647517
61a3c01
772c582
50d6126
dbe48d2
43e7f5f
9c6616f
71347c9
dfa163c
cced81d
4b11198
c2869c3
49cf1a8
6bd9a55
eafb9cb
82592b6
4ad4813
f435204
98e86d9
e1bbea5
67151b8
b8cf219
96aaa36
52b9adb
7edc408
dc9f0bd
0faf725
ec34f1e
95bb1ca
b844f80
7c1d6c3
c6a9496
9e64c30
12472bc
90bdc59
171504f
665a805
39d05ec
1cae6bb
09b7c7b
962fc3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pattern we've adopted in the other subpackages is to have each
__init__.py
import all of the modules in that subpackage. Should we do that here? Or should we be doing something different everywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that the imports within
__init__.py
are strictly necessary, and in my experience it's pretty common practice to have empty__init__.py
files in sub-packages. I always thought it was more if you want to make code from a module available in the package level namespace you could import it in__init__.py
, but python doesn't have a problem finding modules within a package. All that said, I don't really feel like I have a firm grasp on import best practices, and I'm totally fine with sticking with the pattern used elsewhere for consistency.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some failures in the steam table processing due to
pudl.analysis.fuel_by_plant
not being imported inpudl/analysis/__init__.py
and we have a lot of places where we just import a whole module, rather than the individual functions or constants within it, so I feel like adding the imports here for now would help avoid some confusion with that pattern breaking on some modules.