-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make association assets names more consistent #3035
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I decided to just recreate all of the migrations again because we're I ran into some migration conflicts and we're going to recreate them before we merge |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rename-core-assets #3035 +/- ##
====================================================
- Coverage 88.6% 88.6% -0.1%
====================================================
Files 91 91
Lines 11021 11017 -4
====================================================
- Hits 9773 9769 -4
Misses 1248 1248
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor internal inconsistency I noticed was that now the epacamd_eia.py
module is named differently from the reordered assets that it helps produce, and it seemed like having them named the same would be more intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, should we also ensure that the module names match the asset names? With the reordering, they no longer match.
Looks like there are a lot of instances of |
PR Overview
This PR makes association assets more consistent by alphabetizing the linked sources and making sure linked sources come before linked entity names. See #3030 for more details.
PR Checklist
dev
).