Map PHMSA Natural Gas Transmission Part L columns #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-belfer
added
new-data
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
=====================================
Coverage 92.7% 92.7%
=====================================
Files 144 144
Lines 13087 13091 +4
=====================================
+ Hits 12128 12134 +6
+ Misses 959 957 -2 ☔ View full report in Codecov by Sentry. |
jdangerx
approved these changes
Jan 22, 2024
| commodity_group,,,,,,,,,,,,,,,,,,,,,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity,parta5commodity | ||
| interstate_or_intrastate,,,,,,,,,,,,,,,,,,,,,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra,inter_intra | ||
| report_state,,,,,,,,,,,,stop,stop,stop,stop,stop,stop,stop,stop,stop,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name,state_name | ||
| onshore_transmission_pipe_class_1_miles,,,,,,,,,,,,b4ton_1,b4ton_1,b4ton_1,b4ton_1,b4ton_1,b4ton_1,b4ton_1,b4ton_1,b4ton_1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1,partltonc1 |
There was a problem hiding this comment.
I think we are a little inconsistent about the ordering of onshore/offshore and transmission/gathering:
> ag ^onshore_ -c
yearly_miles_of_pipe_by_class_location.csv:25
yearly_miles_of_transmission_pipe_by_nps.csv:35
yearly_miles_of_gathering_pipe_by_nps.csv:95
> ag ^transmission_onshore -c
yearly_transmission_gathering_summary_by_commodity.csv:1
> ag ^gathering_onshore -c
yearly_transmission_gathering_summary_by_commodity.csv:4
It appears that "shoreyness" comes before "transmissioniness" in most cases, should we standardize that everywhere?
There was a problem hiding this comment.
I think in the transmission_pipe_by_nps and gathering_pipe_by_nps transmission/gathering are implied, so they're not explicitly spelled out. I can flip the summary_by_commodity usage to more closely reflect the one in class_location though.
For more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3253.
What problem does this address?
Extracts Part L in a raw format for PHMSA transmission data into one table,
raw_phmsagas__yearly_miles_of_pipe_by_class_location. This table includes data from 2001-2022.What did you change?
Mapped columns for the relevant table, and updated the remaining CSVs in
src/pudl/package_data/phmsagas.Testing
How did you make sure this worked? How can a reviewer verify this?
Materialize the raw asset in dagster. Also run the table through the notebook and verify columns are correctly mapped, for additional peace of mind.
To-do list