Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate 2023 EIA 860 Early Release #3681

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Integrate 2023 EIA 860 Early Release #3681

merged 11 commits into from
Jun 21, 2024

Conversation

cmgosnell
Copy link
Member

@cmgosnell cmgosnell commented Jun 18, 2024

Overview

Closes #3676.

What problem does this address?

What did you change?

Testing

How did you make sure this worked? How can a reviewer verify this?

To-do list

@cmgosnell cmgosnell self-assigned this Jun 18, 2024
@cmgosnell cmgosnell requested a review from e-belfer June 18, 2024 15:32
@cmgosnell cmgosnell added eia860 Anything having to do with EIA Form 860 rmi data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Jun 18, 2024
@cmgosnell cmgosnell marked this pull request as draft June 18, 2024 15:39
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

devtools/debug-column-mapping.ipynb Show resolved Hide resolved
src/pudl/metadata/classes.py Show resolved Hide resolved
src/pudl/metadata/fields.py Show resolved Hide resolved
src/pudl/metadata/resources/eia860.py Show resolved Hide resolved
src/pudl/transform/eia860.py Outdated Show resolved Hide resolved
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of relatively minor comments on naming conventions. Currently running the assets locally, no problem so far.

src/pudl/metadata/fields.py Show resolved Hide resolved
src/pudl/metadata/resources/eia860.py Show resolved Hide resolved
src/pudl/transform/eia860.py Outdated Show resolved Hide resolved
src/pudl/transform/eia860.py Outdated Show resolved Hide resolved
@cmgosnell cmgosnell marked this pull request as ready for review June 20, 2024 14:07
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if all the tests pass on your end go ahead and merge!

src/pudl/helpers.py Outdated Show resolved Hide resolved
src/pudl/helpers.py Outdated Show resolved Hide resolved
src/pudl/helpers.py Outdated Show resolved Hide resolved
src/pudl/helpers.py Outdated Show resolved Hide resolved
@cmgosnell cmgosnell enabled auto-merge June 21, 2024 16:02
@cmgosnell cmgosnell added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 056961b Jun 21, 2024
14 checks passed
@cmgosnell cmgosnell deleted the 2023-eia860-er branch June 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates eia860 Anything having to do with EIA Form 860 rmi
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Integrate EIA860 2023 Early Release Data
3 participants