-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate 2023 EIA 860 Early Release #3681
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
src/pudl/package_data/eia860/column_maps/generator_energy_storage_retired.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of relatively minor comments on naming conventions. Currently running the assets locally, no problem so far.
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
migrations/versions/9891f104b622_add_new_storage_and_solar_columns_from_.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, if all the tests pass on your end go ahead and merge!
migrations/versions/b9b6cb1a5405_add_2023_eia_860er_storage_and_solar_.py
Show resolved
Hide resolved
Co-authored-by: E. Belfer <[email protected]>
Overview
Closes #3676.
What problem does this address?
What did you change?
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list