Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eia923 er validation test fix #3734

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Eia923 er validation test fix #3734

merged 1 commit into from
Jul 24, 2024

Conversation

aesharpe
Copy link
Member

Overview

Closes #3733.

What problem does this address?

Fix nightly build fail.

What did you change?

updates minmax row validation tests in the mcoe module.

@aesharpe aesharpe added eia923 Anything having to do with EIA Form 923 data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Jul 24, 2024
@aesharpe aesharpe requested a review from e-belfer July 24, 2024 15:30
@aesharpe aesharpe self-assigned this Jul 24, 2024
@aesharpe aesharpe removed the request for review from e-belfer July 24, 2024 15:32
@aesharpe aesharpe removed eia923 Anything having to do with EIA Form 923 data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Jul 24, 2024
@aesharpe aesharpe removed their assignment Jul 24, 2024
@aesharpe aesharpe force-pushed the eia923-er-validation-test-fix branch from a63aab6 to d27c96f Compare July 24, 2024 16:38
@aesharpe aesharpe requested a review from e-belfer July 24, 2024 16:38
@aesharpe aesharpe self-assigned this Jul 24, 2024
@aesharpe aesharpe added eia923 Anything having to do with EIA Form 923 data-update When fresh data is integrated into PUDL from quarterly or annual updates labels Jul 24, 2024
@e-belfer e-belfer marked this pull request as ready for review July 24, 2024 17:09
Copy link
Member

@e-belfer e-belfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@aesharpe aesharpe added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 9188f8d Jul 24, 2024
12 checks passed
@aesharpe aesharpe deleted the eia923-er-validation-test-fix branch July 24, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-update When fresh data is integrated into PUDL from quarterly or annual updates eia923 Anything having to do with EIA Form 923
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nightly Build Failure 2024-07-24
2 participants