Add extra extenstions #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keevan
reviewed
Jan 24, 2024
classes/converter.php
Outdated
| @@ -42,18 +42,26 @@ class converter implements \core_files\converter_interface { | |||
| /** @var array $imports List of supported import file formats */ | |||
| private static $imports = [ | |||
| 'doc' => 'application/msword', | |||
| 'docm' => 'application/vnd.ms-word.document.macroEnabled.12 ', | |||
There was a problem hiding this comment.
Extra space at the end. Is this intentional?
There was a problem hiding this comment.
Thanks @keevan,
I have missed this one, there should be no space. I have updated the MR
There was a problem hiding this comment.
There was a problem hiding this comment.
I have removed "macro enabled" extension, as there is potential security issue
tuanngocnguyen
force-pushed
the
extra_extensions
branch
from
e42d989
to
4e50fbf
Compare
tuanngocnguyen
force-pushed
the
extra_extensions
branch
from
4e50fbf
to
9d81d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extension variants for MS word, excel, powerpoint, and jpg (plus csv)
I have run the following command
./instdir/program/soffice.bin --headless --invisible --nodefault --nofirststartwizard \ --nolockcheck --nologo --norestore --convert-to pdf --outdir $(pwd) afile.extensionThe conversion completed successfully for those extensions.