Skip to content

Commit

Permalink
Fix #180: Check if adhoc tasks are queued before log output
Browse files Browse the repository at this point in the history
  • Loading branch information
djarran committed Nov 21, 2024
1 parent ff91925 commit 9ee450d
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,14 @@ function reengagement_crontask() {

// First: add 'in-progress' records for those users who are able to start.
foreach ($reengagements as $reengagementcm) {
if (debugging('', DEBUG_DEVELOPER) || ($reengagementcm->cmid && debugging('', DEBUG_ALL))) {
mtrace("Adding adhoc task for course module id " . $reengagementcm->cmid);
$isqueued = reengagement_queue_adhoc_task($reengagementcm);
if (!$isqueued) {
debugging('', DEBUG_DEVELOPER) &&
mtrace("Skipped queueing re-engagement module: (rid: $reengagementcm->rid, cmid: $reengagementcm->cmid)");
continue;
}
reengagement_queue_adhoc_task($reengagementcm);
debugging('', DEBUG_DEVELOPER) &&
mtrace("Queued re-engagement module: (rid: $reengagementcm->rid, cmid: $reengagementcm->cmid)");
}
$reengagements->close();

Expand Down Expand Up @@ -840,5 +844,5 @@ function reengagement_queue_adhoc_task($reengagementcm) {
$task->set_custom_data($customdata);

// Queue the task.
manager::queue_adhoc_task($task, true);
return manager::queue_adhoc_task($task, true);
}

0 comments on commit 9ee450d

Please sign in to comment.