-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Adhoc Task for Each Course Module #164
Add Adhoc Task for Each Course Module #164
Conversation
7a29509
to
65e5fe5
Compare
The CI failed due to deprecated 404 Behat tests, which aren't related to this change. However, I've addressed the 404 test issue in this branch. If you prefer, we can create a separate branch specifically for the 404 fix, including the updated Behat test." |
Hi @danmarsden |
no objections to the concept - if someone has carefully peer reviewed the patch and made sure it does pretty much the same thing - of course this needs to land in the latest branch "first" before the 400_STABLE branch is merged in but happy for you to hit the merge button on your end if that's done. |
Refactor reengagement_adhoc_task.php to remove unnecessary check for empty startusers array Fix typo in reengagement_adhoc_task.php comment
Fix: ci codechecker errors
8035bd0
to
68d7f81
Compare
Thanks, @danmarsden , for creating the new MOODLE_404_STABLE branch. Since we now have a dedicated branch for 404, all the tests are passing on this PR. Please check and confirm. |
I’ve created another PR #174 for the latest branch by cherry-picking the commit that splits the scheduled task into an adhoc_task for each course module. Please check and confirm. |
This update introduces an adhoc task for each course module.
classes/task/reengagement_adhoc_task.php
to handle the adhoc task logic.lib.php
to integrate the adhoc task functionality.