Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #180: Check if adhoc tasks are queued before log output #186

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix #180: Check if adhoc tasks are queued before log output #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,14 @@ function reengagement_crontask() {

// First: add 'in-progress' records for those users who are able to start.
foreach ($reengagements as $reengagementcm) {
if (debugging('', DEBUG_DEVELOPER) || ($reengagementcm->cmid && debugging('', DEBUG_ALL))) {
mtrace("Adding adhoc task for course module id " . $reengagementcm->cmid);
$isqueued = reengagement_queue_adhoc_task($reengagementcm);
if (!$isqueued) {
debugging('', DEBUG_DEVELOPER) &&
mtrace("Skipped queueing re-engagement module: (rid: $reengagementcm->rid, cmid: $reengagementcm->cmid)");
continue;
}
reengagement_queue_adhoc_task($reengagementcm);
debugging('', DEBUG_DEVELOPER) &&
mtrace("Queued re-engagement module: (rid: $reengagementcm->rid, cmid: $reengagementcm->cmid)");
}
$reengagements->close();

Expand Down Expand Up @@ -840,5 +844,5 @@ function reengagement_queue_adhoc_task($reengagementcm) {
$task->set_custom_data($customdata);

// Queue the task.
manager::queue_adhoc_task($task, true);
return manager::queue_adhoc_task($task, true);
}
Loading