Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probabilistic counting #336 #339

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

bwalkerl
Copy link
Contributor

Closes #336

The updated logic should cover the intent mentioned on the issue, though this will have slightly different results compared to the previous implementation.

@bwalkerl bwalkerl force-pushed the fix-prob-counting branch from 827862d to 7ea5e73 Compare April 17, 2024 02:07
classes/manager.php Outdated Show resolved Hide resolved
@bwalkerl bwalkerl force-pushed the fix-prob-counting branch 3 times, most recently from 852dc10 to 4a37629 Compare April 19, 2024 05:03
@bwalkerl bwalkerl force-pushed the fix-prob-counting branch from 4a37629 to 618e3dc Compare April 19, 2024 05:11
@bwalkerl
Copy link
Contributor Author

Latest pushes include:

  • Updating unit test to be deterministic
  • Fixing a bug where the approximation was starting at 2 instead of 1. The display seemed to be intentionally using lower values because of this, so that has also been adjusted (including removing the range - because the way the range was calculated didn't make sense).

@brendanheywood brendanheywood merged commit 6735abf into MOODLE_35_STABLE Apr 22, 2024
25 checks passed
@brendanheywood brendanheywood deleted the fix-prob-counting branch April 22, 2024 01:52
@bwalkerl bwalkerl mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probabilistic counting of pages is not working correctly
2 participants