Fix cime and unit test

grade/penalty/duedate/lang/en/gradepenalty_duedate.php

@@ -33,7 +33,6 @@
 $string['error_penalty_abovevalue'] = 'The penalty must be greater than the value of above rule: {$a}%.';
 $string['error_penalty_maxvalue'] = 'The penalty cannot be greater than {$a}%.';
 $string['error_penalty_minvalue'] = 'The penalty must be greater than or equal to {$a}%.';
-$string['error_penalty_minvalue'] = 'The penalty must be greater than or equal to {$a}%.';
 $string['existingrule'] = 'Existing rules';
 $string['finalpenaltyrule'] = 'Final penalty rule';
 $string['finalpenaltyrule_help'] = 'The penalty system uses the first matching rule found. If no rules match, the final rule is applied.';

grade/penalty/duedate/templates/view_penalty_rule_action_bar.mustache

@@ -20,7 +20,7 @@
     {
         "title": "Penalty rule",
         "editbutton": {
-           "id": "single_button12345",
+           "id": "single_button123",
             "method" : "get",
             "classes": "singlebutton",
             "formid": null,
@@ -31,7 +31,7 @@
             "attributes": []
         },
         "resetbutton": {
-           "id": "single_button12345",
+           "id": "single_button456",
             "method" : "get",
             "classes": "singlebutton",
             "formid": null,

grade/penalty/duedate/tests/penalty_test_base.php

@@ -34,6 +34,10 @@ abstract class penalty_test_base extends advanced_testcase {
      */
     public function create_sample_rules(int $contextid = 1): void {
         global $DB;
+
+        // Remove initial rule.
+        $DB->delete_records('gradepenalty_duedate_rule', ['contextid' => $contextid]);
+
         $rules = [
             ['contextid' => $contextid, 'overdueby' => DAYSECS, 'penalty' => 10, 'sortorder' => 0],
             ['contextid' => $contextid, 'overdueby' => DAYSECS * 2, 'penalty' => 20, 'sortorder' => 1],