Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement audit fixes #40

Merged
merged 16 commits into from
Apr 2, 2024
Merged

Implement audit fixes #40

merged 16 commits into from
Apr 2, 2024

Conversation

reednaa
Copy link
Member

@reednaa reednaa commented Mar 20, 2024

This PR implements all of the audit fixes in 1 PR. This simplifies merging since each merge requires updating the respective gas arguments.

resolves #39, #38, #37, #36, #35, #34, #33, #32

Copy link
Member

@jsanmigimeno jsanmigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor README comments, the revert error NotEnoughGasExeuction name must also be corrected.

Logicwise seems good.

@reednaa reednaa requested a review from jsanmigimeno March 22, 2024 09:09
Copy link
Member

@jsanmigimeno jsanmigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert error NotEnoughGasExeuction is misspelt.

@reednaa
Copy link
Member Author

reednaa commented Apr 2, 2024

Revert error NotEnoughGasExeuction is misspelt.

Sorry, forgot to push.

@reednaa reednaa requested a review from jsanmigimeno April 2, 2024 10:50
@reednaa reednaa merged commit e410087 into main Apr 2, 2024
1 check passed
@reednaa reednaa deleted the post-audit-fixes branch April 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants