Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Store Refactor #47

Merged
merged 5 commits into from
Jul 19, 2024
Merged

[chore]: Store Refactor #47

merged 5 commits into from
Jul 19, 2024

Conversation

jsanmigimeno
Copy link
Member

Changes summary:

  • The Store is now not chainId dependent. Wormhole engine does not need to load a store per chain anymore.
  • Fixed AMBMessages/AMBProofs of the ack messages overwriting those of the delivery messages.
  • The toIncentivesAddress is now saved to the AMBMessage type (no need for a separate registerDestinationAddress call). Persister also updated. Having a standalone function increased the likelihood of missing its implementation (e.g. on the LZ collector)
  • Wormhole recovery worker now also recovers the transaction block hash and number (required by the new Store data types)
  • The way the events are stored has been streamlined. The Bounty structure has been overhauled.
    • Remove unused ‘finalised’ field
    • Fix the unused ‘status’ field (the field was not being updated on message delivery/bounty claimed)
  • Fixed how the 'amb messages by transaction hash' logic works (prevent data loss)
  • Generalised the way in which custom collectors can save data to Redis.

@jsanmigimeno jsanmigimeno added the enhancement New feature or request label Jul 19, 2024
@jsanmigimeno jsanmigimeno self-assigned this Jul 19, 2024
@jsanmigimeno jsanmigimeno merged commit 2bb6d47 into testnet Jul 19, 2024
1 check passed
@jsanmigimeno jsanmigimeno deleted the jsanmi/store-refactor branch July 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant