Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imaging timestamps using new conversion option always_write_timestamps #16

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Nov 12, 2024

To be reviewed after merging #15
Add imaging timestamps using new conversion option always_write_timestamps

@h-mayorquin
Copy link
Collaborator

The other PRs can be merged now. Let me know when to take a look at this.

@alessandratrapani
Copy link
Collaborator Author

You can review this already, it is pretty straight forward

@h-mayorquin
Copy link
Collaborator

I am confused because I see a lot of code that I think we already merged? Let me check

@alessandratrapani
Copy link
Collaborator Author

I am confused because I see a lot of code that I think we already merged? Let me check

Sometimes it does not update right away. Now it should be ok

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, indeed it was straightforward : )

@alessandratrapani alessandratrapani merged commit c198f87 into main Nov 14, 2024
1 check failed
@h-mayorquin h-mayorquin deleted the add_imaging_timestamps branch November 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants